Skip to content

XML Water Commands and Messages#928

Closed
nanomad wants to merge 1 commit into
DeebotUniverse:devfrom
nanomad:feature/xml-water-commands-and-messages
Closed

XML Water Commands and Messages#928
nanomad wants to merge 1 commit into
DeebotUniverse:devfrom
nanomad:feature/xml-water-commands-and-messages

Conversation

@nanomad

@nanomad nanomad commented Apr 27, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@nanomad nanomad changed the title Add first batch of XML Water related commands and messages XML Water Commands and Messages Apr 27, 2025
@codecov

codecov Bot commented Apr 27, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.71%. Comparing base (4cc81d1) to head (2eb9e77).
Report is 81 commits behind head on dev.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
deebot_client/commands/xml/water_info.py 70.00% 9 Missing ⚠️
deebot_client/messages/xml/water_info.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #928      +/-   ##
==========================================
- Coverage   92.84%   92.71%   -0.14%     
==========================================
  Files         125      127       +2     
  Lines        4865     4913      +48     
  Branches      315      320       +5     
==========================================
+ Hits         4517     4555      +38     
- Misses        285      295      +10     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Apr 27, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #928 will not alter performance

Comparing nanomad:feature/xml-water-commands-and-messages (2eb9e77) with dev (4cc81d1)

Summary

✅ 6 untouched benchmarks

@nanomad nanomad force-pushed the feature/xml-water-commands-and-messages branch from 86e11c7 to 2eb9e77 Compare April 29, 2025 09:54
@nanomad

nanomad commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

PR on hold while I await for a replacement battery 😢

@edenhaus

Copy link
Copy Markdown
Member

Closing the PR as it is stale. Feel free to reopen if you want to continue on it

@edenhaus edenhaus closed this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants